OSDN Git Service

media: aspeed-video: address a protential usage of an unitialized var
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 22 Aug 2019 14:46:40 +0000 (11:46 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 26 Aug 2019 17:03:39 +0000 (14:03 -0300)
commit31b8b0bd6e55c3ea5a08bb8141fa5d3c90600e3b
treeca19285893c27214fac3f6a122cc950865bcdbac
parentcb8045072a34d113e51fcd19cec74359b4e8daa9
media: aspeed-video: address a protential usage of an unitialized var

While this might not occur in practice, if the device is doing
the right thing, it would be teoretically be possible to have
both hsync_counter and vsync_counter negatives.

If this ever happen, ctrl will be undefined, but the driver
will still call:

aspeed_video_update(video, VE_CTRL, 0, ctrl);

Change the code to prevent this to happen.

This was warned by cppcheck:

[drivers/media/platform/aspeed-video.c:653]: (error) Uninitialized variable: ctrl

Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/aspeed-video.c