OSDN Git Service

net/mlx5: fix uaccess beyond "count" in debugfs read/write handlers
authorJann Horn <jannh@google.com>
Fri, 6 Jul 2018 20:18:09 +0000 (22:18 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Wed, 11 Jul 2018 19:08:57 +0000 (12:08 -0700)
commit31e33a5b41bb158f27c30e13b12d6e5e6513ea05
tree85eee11c59220deeb4139b913385e43e91be4ba2
parentb183ee27f5fb07c8428e2fe45d5f35dac611c45d
net/mlx5: fix uaccess beyond "count" in debugfs read/write handlers

In general, accessing userspace memory beyond the length of the supplied
buffer in VFS read/write handlers can lead to both kernel memory corruption
(via kernel_read()/kernel_write(), which can e.g. be triggered via
sys_splice()) and privilege escalation inside userspace.

In this case, the affected files are in debugfs (and should therefore only
be accessible to root) and check that *pos is zero (which prevents the
sys_splice() trick). Therefore, this is not a security fix, but rather a
small cleanup.

For the read handlers, fix it by using simple_read_from_buffer() instead of
custom logic.
For the write handler, add a check.

changed in v2:
 - also fix dbg_write()

Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: Jann Horn <jannh@google.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/cmd.c
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c