OSDN Git Service

net: stmmac: set get_rx_header_len() as void for it didn't have any error code to...
authorLuo Jiaxing <luojiaxing@huawei.com>
Fri, 11 Sep 2020 03:55:58 +0000 (11:55 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Sep 2020 21:37:34 +0000 (14:37 -0700)
commit31f2760e41d3315e01895c4a9f9d365a5549ebfa
tree253c02497936f3651c98c450f9e96a20020abed9
parent5bc461fd565a487c53bac230af090c104535f43f
net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

We found the following warning when using W=1 to build kernel:

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
int ret, coe = priv->hw->rx_csum;

When digging stmmac_get_rx_header_len(), dwmac4_get_rx_header_len() and
dwxgmac2_get_rx_header_len() return 0 only, without any error code to
report. Therefore, it's better to define get_rx_header_len() as void.

Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
drivers/net/ethernet/stmicro/stmmac/hwif.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c