OSDN Git Service

Move code from SuggestionChecks to FeatureProvider
authorFan Zhang <zhfan@google.com>
Fri, 29 Sep 2017 00:17:44 +0000 (17:17 -0700)
committerFan Zhang <zhfan@google.com>
Fri, 29 Sep 2017 18:36:16 +0000 (11:36 -0700)
commit31f699c281dfeecf9f8911a46eaf49a052d9ef90
treee5a375bf7a2062e547c6b0f1264f29b169bc5f79
parentb963125159921da2ec50c0447a2afd248a156eda
Move code from SuggestionChecks to FeatureProvider

This is step one to deprecate SuggestionChecks. Moving logic into
SuggestionFeatureProvider allows potential logic override and improves
testability.

Also moved isSuggestionComplete tests to corresponding activity/pref
controller test.

Bug: 65065268
Test: robotests
Change-Id: I2071d30fc58bb84acad2083ca03cfcf7d41f10cb
23 files changed:
AndroidManifest.xml
src/com/android/settings/Settings.java
src/com/android/settings/dashboard/suggestions/SuggestionFeatureProvider.java
src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImpl.java
src/com/android/settings/dashboard/suggestions/SuggestionsChecks.java
src/com/android/settings/fingerprint/FingerprintEnrollSuggestionActivity.java [new file with mode: 0644]
src/com/android/settings/fingerprint/FingerprintSuggestionActivity.java
src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java
src/com/android/settings/gestures/PickupGesturePreferenceController.java
src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java
src/com/android/settings/password/ScreenLockSuggestionActivity.java [new file with mode: 0644]
src/com/android/settings/wallpaper/WallpaperSuggestionActivity.java
src/com/android/settings/wifi/WifiCallingSuggestionActivity.java [new file with mode: 0644]
tests/robotests/src/com/android/internal/hardware/AmbientDisplayConfiguration.java
tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionFeatureProviderImplTest.java
tests/robotests/src/com/android/settings/fingerprint/FingerprintEnrollSuggestionActivityTest.java [moved from tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionsChecksTest.java with 63% similarity]
tests/robotests/src/com/android/settings/gestures/DoubleTapPowerPreferenceControllerTest.java
tests/robotests/src/com/android/settings/gestures/DoubleTapScreenPreferenceControllerTest.java
tests/robotests/src/com/android/settings/gestures/DoubleTwistPreferenceControllerTest.java
tests/robotests/src/com/android/settings/gestures/PickupGesturePreferenceControllerTest.java
tests/robotests/src/com/android/settings/gestures/SwipeToNotificationPreferenceControllerTest.java
tests/robotests/src/com/android/settings/suggestions/SettingsSuggestionsTest.java
tests/robotests/src/com/android/settings/wallpaper/WallpaperSuggestionActivityTest.java