OSDN Git Service

drm/mediatek: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 22 May 2023 15:53:06 +0000 (15:53 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 1 Jun 2023 14:07:37 +0000 (07:07 -0700)
commit3213bfde114f9ce37e2a0264d368dcf8a2347bea
tree0cad7b657ed1334111a377d6f0aef706c3c0c111
parent576f0d7a8ad3219a35d06a297005cc1aa14ae96f
drm/mediatek: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155306.2336889-1-azeemshaikh38@gmail.com
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c