OSDN Git Service

net: dsa: sja1105: don't keep a persistent reference to the reset GPIO
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 22 Sep 2021 15:10:29 +0000 (18:10 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Sep 2021 11:46:22 +0000 (12:46 +0100)
commit33e1501f5a5fd1d682d43c4f5a03bc6c9a742d1e
treecd92d4ea4d8bb27a580ae527d019057ca3800573
parenta7597f79d3b1d040c347adfd50ec0d50483deba0
net: dsa: sja1105: don't keep a persistent reference to the reset GPIO

The driver only needs the reset GPIO for a very brief period, so instead
of using devres and keeping the descriptor pointer inside priv, just use
that descriptor inside the sja1105_hw_reset function and then let go of
it.

Also use gpiod_get_optional while at it, and error out on real errors
(bad flags etc).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105.h
drivers/net/dsa/sja1105/sja1105_main.c