OSDN Git Service

[media] tw5864-core: remove excessive irqsave
authorAndrey Utkin <andrey.utkin@corp.bluecherry.net>
Wed, 24 Aug 2016 23:17:18 +0000 (20:17 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Sep 2016 19:45:48 +0000 (16:45 -0300)
commit350649cc24358ab0cfff7179c06818d0cfef698b
tree26018ea4c24eb007520da7300efec35923253780
parente5872251cdf59ad284eb7ebb5960208d1753d9d8
[media] tw5864-core: remove excessive irqsave

As warned by smatch:
drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags'
drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags'

Two different spinlocks are obtained, so having two calls is correct,
but second irqsave is superfluous, and using same "flags" variable is
just wrong.

Reported-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/tw5864/tw5864-core.c