OSDN Git Service

net: ethernet: ti: cpsw: fix extra rx interrupt
authorGrygorii Strashko <grygorii.strashko@ti.com>
Fri, 6 Dec 2019 12:28:20 +0000 (14:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Dec 2019 09:35:42 +0000 (10:35 +0100)
commit3569dc395a0515d8b62a5dec6228056ad309d9e6
tree91d54788942b7cceeb1dbca6c71bcb5edc254187
parent81ff88ec7b86c3bb01c1a256ec52da218c62bd17
net: ethernet: ti: cpsw: fix extra rx interrupt

[ Upstream commit 51302f77bedab8768b761ed1899c08f89af9e4e2 ]

Now RX interrupt is triggered twice every time, because in
cpsw_rx_interrupt() it is asked first and then disabled. So there will be
pending interrupt always, when RX interrupt is enabled again in NAPI
handler.

Fix it by first disabling IRQ and then do ask.

Fixes: 870915feabdc ("drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/ti/cpsw.c