OSDN Git Service

mt76: fix memcpy to potential null pointer on failed allocation
authorColin Ian King <colin.king@canonical.com>
Thu, 14 Dec 2017 10:13:22 +0000 (10:13 +0000)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 8 Jan 2018 17:27:44 +0000 (19:27 +0200)
commit364bea50dbea0af94e80d95ca771b87af818c0b8
tree0423f750592b83b331a3b6786f116f48ca865a32
parenta86af66f9b0cacd8e9e6a8fd9e7cf9db624765be
mt76: fix memcpy to potential null pointer on failed allocation

Currently if the allocation of skb fails and returns NULL then the
call to skb_put will cause a null pointer dereference. Fix this by
checking for a null skb and returning NULL.  Note that calls to
function mt76x2_mcu_msg_alloc don't directly check the null return
but instead pass the NULL pointer to mt76x2_mcu_msg_send which
checks for the NULL and returns ENOMEM in this case.

Detected by CoverityScan, CID#1462624 ("Dereference null return value")

Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c