OSDN Git Service

media: davinci: don't override the error code
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 23 Apr 2018 11:22:19 +0000 (07:22 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 4 May 2018 12:59:37 +0000 (08:59 -0400)
commit366b401001df15e4f493a585ff94a7399d7fae07
treee1c61f664f46eb4ea04a5643c0c6a670e259b9fc
parentfd901b6e814afcbd54ca65a854f666bd6fe98b8f
media: davinci: don't override the error code

As warned by Coverity:
CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
Assigning value -22 to ret here, but that stored value is
overwritten before it can be used.

On all cases where the there's a goto 'unlock_out' or 'streamof',
ret was filled with a non-sero value. It toesn't make sense to override
such error code with a videobuf_streamoff() error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/davinci/vpfe_capture.c