OSDN Git Service

hw/sd/ssi-sd: Do not create SD card within controller's realize
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Nov 2021 16:33:57 +0000 (17:33 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 15 Dec 2021 07:38:16 +0000 (08:38 +0100)
commit36aa285f48d55451bb2eb7a2c0f9635a3c2bbe46
tree0a8643af96e9348b33b8cfe509b147a6ac29320b
parent76b56fdfc9fa43ec6e5986aee33f108c6c6a511e
hw/sd/ssi-sd: Do not create SD card within controller's realize

ssi_sd_realize() creates an "sd-card" device.  This is inappropriate,
and marked FIXME.

Move it to the boards that create these devices.  Prior art: commit
eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for
device "pl181".

The device remains not user-creatable, because its users should (and
do) wire up its GPIO chip-select line.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Alistair Francis <Alistair.Francis@wdc.com>
Cc: Bin Meng <bin.meng@windriver.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-arm@nongnu.org
Cc: qemu-riscv@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20211117163409.3587705-2-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
hw/arm/stellaris.c
hw/riscv/sifive_u.c
hw/sd/ssi-sd.c