OSDN Git Service

ALSA: rockchip_i2s: fix a possible divide-by-zero bug in rockchip_i2s_hw_params()
authorTuo Li <tuoli96@outlook.com>
Mon, 7 Sep 2020 13:09:37 +0000 (21:09 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 11 Sep 2020 14:52:20 +0000 (15:52 +0100)
commit375e2c352582442783178e6a33c279d6bc9354a2
treeb44209063ac78a655516f3f3e9aeab8b193642b7
parent2a4b91a26403fa3e7b07271700c3ca7103664bba
ALSA: rockchip_i2s: fix a possible divide-by-zero bug in rockchip_i2s_hw_params()

The variable bclk_rate is checked in:
  if (bclk_rate && mclk_rate % bclk_rate)

This indicates that bclk_rate can be zero.
If so, a divide-by-zero bug will occur:
  div_bclk = mclk_rate / bclk_rate;

To fix this possible bug, the function returns -EINVAL when bclk_rate is
zero.

Signed-off-by: Tuo Li <tuoli96@outlook.com>
Link: https://lore.kernel.org/r/TY2PR04MB4029799E60A5BCAAD5B7B5BBB8280@TY2PR04MB4029.apcprd04.prod.outlook.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s.c