OSDN Git Service

spi/bcm63xx-hspi: fix error return code in bcm63xx_hsspi_probe()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Aug 2017 04:59:44 +0000 (23:59 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 8 Aug 2017 10:36:39 +0000 (11:36 +0100)
commit378da4a65f3a0390837b38145bb5d8c2d20c2cf7
treec6b8d8fa6f35814715be650ab40146df1dfa721b
parentba8afe94723e9ba665aee9cca649fb2c80f7304c
spi/bcm63xx-hspi: fix error return code in bcm63xx_hsspi_probe()

platform_get_irq() returns an error code, but the spi-bcm63xx-hsspi
driver ignores it and always returns -ENXIO. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm63xx-hsspi.c