OSDN Git Service

net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 1 Jun 2023 21:31:04 +0000 (23:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Jun 2023 09:55:41 +0000 (10:55 +0100)
commit37a826d86ff746c4eac8bd3415af19f3c9598206
tree007e241e3d4cbe6b9777c7b424bff2db105c50f0
parentf93b30e50a81a16cefa262b68bde5c4096ea9235
net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency

Without LED triggers, the driver now fails to build:

drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds':
drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported'
  403 |                 port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported;
      |                               ^

There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's
not clear what we should use here, but in general using 'depends on'
causes fewer problems, so use that.

Fixes: e0256648c831a ("net: dsa: qca8k: implement hw_control ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca/Kconfig