OSDN Git Service

drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 22 May 2023 15:52:10 +0000 (15:52 +0000)
committerRobert Foss <rfoss@kernel.org>
Tue, 23 May 2023 17:19:31 +0000 (19:19 +0200)
commit37cee4876a45a5c3da79a83d34ed4f3c68548aef
tree5484b82441906159797eea7f9106868d23f87db8
parent1464e48d69ab7a50a377c9d39f5e5eb3cee2722e
drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230522155210.2336690-1-azeemshaikh38@gmail.com
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c