OSDN Git Service

dh key: get rid of stack allocated array
authorTycho Andersen <tycho@tycho.ws>
Tue, 24 Apr 2018 20:26:38 +0000 (14:26 -0600)
committerJames Morris <james.morris@microsoft.com>
Fri, 11 May 2018 20:07:47 +0000 (13:07 -0700)
commit383203eff718d7397ffc68ac6c3ed644d3017fc7
tree2218547fb400fa5b4425ec29fddfea65d95c0d96
parenta964f395614af195cf5c5caa84a9c487b86d5ba5
dh key: get rid of stack allocated array

We're interested in getting rid of all of the stack allocated arrays in the
kernel: https://lkml.org/lkml/2018/3/7/621

This particular vla is used as a temporary output buffer in case there is
too much hash output for the destination buffer. Instead, let's just
allocate a buffer that's big enough initially, but only copy back to
userspace the amount that was originally asked for.

v2: allocate enough in the original output buffer vs creating a temporary
    output buffer

Signed-off-by: Tycho Andersen <tycho@tycho.ws>
Reviewed-by: Kees Cook <keescook@chromium.org>
CC: David Howells <dhowells@redhat.com>
CC: James Morris <jmorris@namei.org>
CC: "Serge E. Hallyn" <serge@hallyn.com>
CC: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
security/keys/dh.c