OSDN Git Service

ALSA: hda: intel-sdw-acpi: harden detection of controller
authorLibin Yang <libin.yang@intel.com>
Tue, 21 Dec 2021 01:08:16 +0000 (09:08 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 22 Dec 2021 19:17:37 +0000 (20:17 +0100)
commit385f287f9853da402d94278e59f594501c1d1dad
treeaf7fd09adc9ccbc5317ce064bad5a746c405ab1f
parentb6fd77472dea76b7a2bad3a338ade920152972b8
ALSA: hda: intel-sdw-acpi: harden detection of controller

The existing code currently sets a pointer to an ACPI handle before
checking that it's actually a SoundWire controller. This can lead to
issues where the graph walk continues and eventually fails, but the
pointer was set already.

This patch changes the logic so that the information provided to
the caller is set when a controller is found.

Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Libin Yang <libin.yang@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20211221010817.23636-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/intel-sdw-acpi.c