OSDN Git Service

iio: chemical: sunrise_co2: set val parameter only on success
authorTom Rix <trix@redhat.com>
Fri, 24 Dec 2021 15:08:33 +0000 (07:08 -0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 28 Dec 2021 18:37:41 +0000 (18:37 +0000)
commit38ac2f038666521f94d4fa37b5a9441cef832ccf
tree640bf9147be8a20c07bc4f90a47a8764f7e8f2e8
parent088879292a0a3672a6acc9215174fbc355ed3daa
iio: chemical: sunrise_co2: set val parameter only on success

Clang static analysis reports this representative warning

sunrise_co2.c:410:9: warning: Assigned value is garbage or undefined
  *val = value;
       ^ ~~~~~

The ealier call to sunrise_read_word can fail without setting
value.  So defer setting val until we know the read was successful.

Fixes: c397894e24f1 ("iio: chemical: Add Senseair Sunrise 006-0-007 driver")
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20211224150833.3278236-1-trix@redhat.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/sunrise_co2.c