OSDN Git Service

netfilter: nf_tables: fix crash when nf_trace is enabled
authorFlorian Westphal <fw@strlen.de>
Thu, 4 Aug 2022 17:26:27 +0000 (19:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Aug 2022 01:50:14 +0000 (18:50 -0700)
commit399a14ec7993d605740de7b2cd5c0ce8407d12ed
tree5dc2ddb6abb182b1ee7fc14458ddf3387f7d6fbf
parent2e64fe4624d19bc71212aae434c54874e5c49c5a
netfilter: nf_tables: fix crash when nf_trace is enabled

do not access info->pkt when info->trace is not 1.
nft_traceinfo is not initialized, except when tracing is enabled.

The 'nft_trace_enabled' static key cannot be used for this, we must
always check info->trace first.

Pass nft_pktinfo directly to avoid this.

Fixes: e34b9ed96ce3 ("netfilter: nf_tables: avoid skb access on nf_stolen")
Reported-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/netfilter/nf_tables_core.c