OSDN Git Service

infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 11 Apr 2018 07:32:25 +0000 (15:32 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 18 Apr 2018 01:57:11 +0000 (19:57 -0600)
commit39e487faaf706fa94bab4d0cf9f543a3430c746e
tree9fbe6b51575f396595115ee250c8d0c7b61d0fec
parent76be04500be2d3e3c0ed7e13d3bc4453b985355b
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4

i40iw_add_mqh_4() is never called in atomic context, because it
calls rtnl_lock() that can sleep.

Despite never getting called from atomic context,
i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/i40iw/i40iw_cm.c