OSDN Git Service

drm/i915/cmdparser: Do not check past the cmd length.
authorMichal Srb <msrb@suse.com>
Mon, 5 Feb 2018 16:04:38 +0000 (16:04 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 5 Feb 2018 20:49:24 +0000 (20:49 +0000)
commit3aec7f871c65eb5f76b4125fda432593c834a6f2
treefbcd9dfa91c91c5ebe4a48a5bdffbe1d2c8611ce
parent2f265fad9756a40c09e3f4dcc62d5d7fa73a9fb2
drm/i915/cmdparser: Do not check past the cmd length.

The command MEDIA_VFE_STATE checks bits at offset +2 dwords. However, it is
possible to have MEDIA_VFE_STATE command with length = 0 + LENGTH_BIAS = 2.
In that case check_cmd will read bits from the following command, or even past
the end of the buffer.

If the offset ends up outside of the command length, reject the command.

Fixes: 351e3db2b363 ("drm/i915: Implement command buffer parsing logic")
Signed-off-by: Michal Srb <msrb@suse.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180205151745.29292-1-msrb@suse.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180205160438.3267-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_cmd_parser.c