OSDN Git Service

nfp: flower: fix error path during representor creation
authorJiri Pirko <jiri@mellanox.com>
Thu, 17 May 2018 10:06:43 +0000 (12:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 May 2018 20:23:29 +0000 (16:23 -0400)
commit3b734ff604d32e3e1d7db877d801818967ad325f
tree94e4b4efbfe94058b2ef64c0d05b6a6b5ff5c2d9
parent6d9f868fc7d3b3137638895d659b986a49253a7d
nfp: flower: fix error path during representor creation

Don't store repr pointer to reprs array until the representor is
successfully created. This avoids message about "representor
destruction" even when it was never created. Also it cleans-up the flow.
Also, check return value after port alloc.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/main.c
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
drivers/net/ethernet/netronome/nfp/nfp_net_repr.h