OSDN Git Service

crypto: chtls - wait for memory sendmsg, sendpage
authorAtul Gupta <atul.gupta@chelsio.com>
Sun, 27 May 2018 15:45:19 +0000 (21:15 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 30 May 2018 16:13:58 +0000 (00:13 +0800)
commit3b8305f5c844685d00637a0ad155e90e423a4445
tree7f9eefab8b29dbd5488af16d09d19b5828f67792
parent09e53d8289477449ddd74cfff640792ca02fa90d
crypto: chtls - wait for memory sendmsg, sendpage

address suspicious code <gustavo@embeddedor.com>

1210       set_bit(SOCK_NOSPACE, &sk->sk_socket->flags);
1211       }

The issue is that in the code above, set_bit is never reached
due to the 'continue' statement at line 1208.

Also reported by bug report:<dan.carpenter@oracle.com>
1210       set_bit(SOCK_NOSPACE, &sk->sk_socket->flags);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not reachable.

Its required to wait for buffer in the send path and takes care of
unaddress and un-handled SOCK_NOSPACE.

v2: use csk_mem_free where appropriate
    proper indent of goto do_nonblock
    replace out with do_rm_wq

Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Atul Gupta <atul.gupta@chelsio.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/chelsio/chtls/chtls.h
drivers/crypto/chelsio/chtls/chtls_io.c
drivers/crypto/chelsio/chtls/chtls_main.c