OSDN Git Service

drm/i915: Remove non-existent pipes from bigjoiner pipe mask
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 18 Nov 2022 18:52:01 +0000 (20:52 +0200)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Tue, 29 Nov 2022 08:49:15 +0000 (08:49 +0000)
commit3c1ea6a5f4f55d4e376675dda16945eb5d9bb4de
treeb04508a1e001c15ca14c4d79f010c267ca8a02c3
parent2f3830544a89af2e72e7fd3d6ca44dd9cffec197
drm/i915: Remove non-existent pipes from bigjoiner pipe mask

bigjoiner_pipes() doesn't consider that:
- RKL only has three pipes
- some pipes may be fused off

This means that intel_atomic_check_bigjoiner() won't reject
all configurations that would need a non-existent pipe.
Instead we just keep on rolling witout actually having
reserved the slave pipe we need.

It's possible that we don't outright explode anywhere due to
this since eg. for_each_intel_crtc_in_pipe_mask() will only
walk the crtcs we've registered even though the passed in
pipe_mask asks for more of them. But clearly the thing won't
do what is expected of it when the required pipes are not
present.

Fix the problem by consulting the device info pipe_mask already
in bigjoiner_pipes().

Cc: stable@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221118185201.10469-1-ville.syrjala@linux.intel.com
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
(cherry picked from commit f1c87a94a1087a26f41007ee83264033007421b5)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/display/intel_display.c