OSDN Git Service

mmc: omap_hsmmc: fix wakeirq handling on removal
authorAndreas Kemnade <andreas@kemnade.info>
Sun, 2 Sep 2018 07:30:58 +0000 (09:30 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 4 Sep 2018 14:28:43 +0000 (16:28 +0200)
commit3c398f3c3bef21961eaaeb93227fa66d440dc83d
tree842d0ec6085aa5793a0c7017f9411f118aa4f6c1
parent57361846b52bc686112da6ca5368d11210796804
mmc: omap_hsmmc: fix wakeirq handling on removal

after unbinding mmc I get things like this:
[  185.294067] mmc1: card 0001 removed
[  185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13

The wakeirq stays in /proc-interrupts

rebinding shows this:
[  289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
[  289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
[  289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling

That bug seems to be introduced by switching from devm_request_irq()
to generic wakeirq handling.

So let us cleanup at removal.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/omap_hsmmc.c