OSDN Git Service

tty: fix data race between tty_init_dev and flush of buf
authorGaurav Kohli <gkohli@codeaurora.org>
Tue, 23 Jan 2018 07:46:34 +0000 (13:16 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Feb 2018 16:39:19 +0000 (17:39 +0100)
commit3c538ad935465d7ba4bf0b5747fadcfdf05311c9
treecfafe960790ce12fc812ca2d37b54c15264b1e35
parenteb6de1af2e7235133a0e2563c09926ca28361095
tty: fix data race between tty_init_dev and flush of buf

commit b027e2298bd588d6fa36ed2eda97447fb3eac078 upstream.

There can be a race, if receive_buf call comes before
tty initialization completes in n_tty_open and tty->disc_data
may be NULL.

CPU0 CPU1
---- ----
 000|n_tty_receive_buf_common()    n_tty_open()
-001|n_tty_receive_buf2() tty_ldisc_open.isra.3()
-002|tty_ldisc_receive_buf(inline) tty_ldisc_setup()

Using ldisc semaphore lock in tty_init_dev till disc_data
initializes completely.

Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c
drivers/tty/tty_ldisc.c
include/linux/tty.h