OSDN Git Service

ext4: Don't skip prefetching BLOCK_UNINIT groups
authorOjaswin Mujoo <ojaswin@linux.ibm.com>
Tue, 30 May 2023 12:33:46 +0000 (18:03 +0530)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 26 Jun 2023 23:34:56 +0000 (19:34 -0400)
commit3c6296046c85333bc52555a670a9093d9e2657bb
tree040a34b7c9ec8d44aa72564ac432f0603b798754
parent1b420011210802a7a1b1e99f30bc1d62c352ac71
ext4: Don't skip prefetching BLOCK_UNINIT groups

Currently, ext4_mb_prefetch() and ext4_mb_prefetch_fini() skip
BLOCK_UNINIT groups since fetching their bitmaps doesn't need disk IO.
As a consequence, we end not initializing the buddy structures and CR0/1
lists for these BGs, even though it can be done without any disk IO
overhead. Hence, don't skip such BGs during prefetch and prefetch_fini.

This improves the accuracy of CR0/1 allocation as earlier, we could have
essentially empty BLOCK_UNINIT groups being ignored by CR0/1 due to their buddy
not being initialized, leading to slower CR2 allocations. With this patch CR0/1
will be able to discover these groups as well, thus improving performance.

Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/dc3130b8daf45ffe63d8a3c1edcf00eb8ba70e1f.1685449706.git.ojaswin@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/mballoc.c