OSDN Git Service

drm/msm: Drop update_fences()
authorRob Clark <robdclark@chromium.org>
Sat, 18 Jun 2022 16:11:18 +0000 (09:11 -0700)
committerRob Clark <robdclark@chromium.org>
Sat, 18 Jun 2022 16:13:32 +0000 (09:13 -0700)
commit3c7a52217a8c1e674a9e15b71a7239d71a4d9cfd
treebb58d42274a94ae96d965906101f55e710a5abc8
parentb4d329c451a299323b26039df97b32896fb46abc
drm/msm: Drop update_fences()

I noticed while looking at some traces, that we could miss calls to
msm_update_fence(), as the irq could have raced with retire_submits()
which could have already popped the last submit on a ring out of the
queue of in-flight submits.  But walking the list of submits in the
irq handler isn't really needed, as dma_fence_is_signaled() will dtrt.
So lets just drop it entirely.

v2: use spin_lock_irqsave/restore as we are no longer protected by the
    spin_lock_irqsave/restore() in update_fences()

Reported-by: Steev Klimaszewski <steev@kali.org>
Fixes: 95d1deb02a9c ("drm/msm/gem: Add fenced vma unpin")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Tested-by: Steev Klimaszewski <steev@kali.org>
Patchwork: https://patchwork.freedesktop.org/patch/490136/
Link: https://lore.kernel.org/r/20220618161120.3451993-1-robdclark@gmail.com
drivers/gpu/drm/msm/msm_fence.c
drivers/gpu/drm/msm/msm_gpu.c