OSDN Git Service

bpftool: Fix error message of strerror
authorTianyi Liu <i.pear@outlook.com>
Wed, 28 Sep 2022 08:09:32 +0000 (16:09 +0800)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 30 Sep 2022 22:40:46 +0000 (15:40 -0700)
commit3ca2fb497440a3c8294f9df0ce7b2c3c9a1c5875
tree7ef24febc2a8323e03331e137d3b42c9ded065d8
parent51e05a8cf8eb34da7473823b7f236a77adfef0b4
bpftool: Fix error message of strerror

strerror() expects a positive errno, however variable err will never be
positive when an error occurs. This causes bpftool to output too many
"unknown error", even a simple "file not exist" error can not get an
accurate message.

This patch fixed all "strerror(err)" patterns in bpftool.
Specially in btf.c#L823, hashmap__append() is an internal function of
libbpf and will not change errno, so there's a little difference.
Some libbpf_get_error() calls are kept for return values.

Changes since v1: https://lore.kernel.org/bpf/SY4P282MB1084B61CD8671DFA395AA8579D539@SY4P282MB1084.AUSP282.PROD.OUTLOOK.COM/
Check directly for NULL values instead of calling libbpf_get_error().

Signed-off-by: Tianyi Liu <i.pear@outlook.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/SY4P282MB1084AD9CD84A920F08DF83E29D549@SY4P282MB1084.AUSP282.PROD.OUTLOOK.COM
tools/bpf/bpftool/btf.c
tools/bpf/bpftool/gen.c
tools/bpf/bpftool/map_perf_ring.c