OSDN Git Service

net/vmw_vsock: improve locking in vsock_connect_timeout()
authorNorbert Slusarek <nslusarek@gmx.net>
Fri, 5 Feb 2021 12:14:05 +0000 (13:14 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Feb 2021 23:03:31 +0000 (15:03 -0800)
commit3d0bc44d39bca615b72637e340317b7899b7f911
tree406396f7f0faf47889c6c7c37b77029dc0e6fd31
parent5d1cbcc990f18edaddddef26677073c4e6fad7b7
net/vmw_vsock: improve locking in vsock_connect_timeout()

A possible locking issue in vsock_connect_timeout() was recognized by
Eric Dumazet which might cause a null pointer dereference in
vsock_transport_cancel_pkt(). This patch assures that
vsock_transport_cancel_pkt() will be called within the lock, so a race
condition won't occur which could result in vsk->transport to be set to NULL.

Fixes: 380feae0def7 ("vsock: cancel packets when failing to connect")
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Norbert Slusarek <nslusarek@gmx.net>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/trinity-f8e0937a-cf0e-4d80-a76e-d9a958ba3ef1-1612535522360@3c-app-gmx-bap12
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/vmw_vsock/af_vsock.c