OSDN Git Service

drm/amd: Make sure image is written to trigger VBIOS image update flow
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 7 Jun 2023 06:41:22 +0000 (01:41 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 13 Jun 2023 21:04:45 +0000 (17:04 -0400)
commit3eb1a3a04056ba3df3205e169b8acc9da0c65a94
tree637c908b35b1ce94cbb44905d36474df480da450
parente61f67749b351c19455ce3085af2ae9af80023bc
drm/amd: Make sure image is written to trigger VBIOS image update flow

The VBIOS image update flow requires userspace to:
1) Write the image to `psp_vbflash`
2) Read `psp_vbflash`
3) Poll `psp_vbflash_status` to check for completion

If userspace reads `psp_vbflash` before writing an image, it's
possible that it causes problems that can put the dGPU into an invalid
state.

Explicitly check that an image has been written before letting a read
succeed.

Cc: stable@vger.kernel.org
Fixes: 8424f2ccb3c0 ("drm/amdgpu/psp: Add vbflash sysfs interface support")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c