OSDN Git Service

x86/hpet: Refactor code using deprecated strncpy() interface to use strscpy()
authorJustin Stitt <justinstitt@google.com>
Tue, 22 Aug 2023 22:13:36 +0000 (22:13 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 24 Aug 2023 19:22:40 +0000 (21:22 +0200)
commit4108d141bfd04cf7b2bbf96e899ee5392f62e8a2
tree304e91a157ed5a06e6d869cd43b27383b6ae03fa
parent1e6f01f7285559a5302e85677b8e59a5de9b0ea5
x86/hpet: Refactor code using deprecated strncpy() interface to use strscpy()

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy`!

In this case, it is a simple swap from `strncpy` to `strscpy`. There is
one slight difference, though. If NUL-padding is a functional
requirement here we should opt for `strscpy_pad`. It seems like this
shouldn't be needed as I see no obvious signs of any padding being
required.

Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Link: https://lore.kernel.org/r/20230822-strncpy-arch-x86-kernel-hpet-v1-1-2c7d3be86f4a@google.com
arch/x86/kernel/hpet.c