OSDN Git Service

r8169: improve rtl8169_start_xmit
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 14 Nov 2020 20:49:53 +0000 (21:49 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 16 Nov 2020 15:54:07 +0000 (07:54 -0800)
commit41294e6a434d4f19e957c55b275ea0324f275009
tree518242e3dcf467be259832e50b63b9cc2822ccd5
parent0064c5c1b3bf2a695c772c90e8dea38426a870ff
r8169: improve rtl8169_start_xmit

Improve the following in rtl8169_start_xmit:
- tp->cur_tx can be accessed in parallel by rtl_tx(), therefore
  annotate the race by using WRITE_ONCE
- avoid checking stop_queue a second time by moving the doorbell check
- netif_stop_queue() uses atomic operation set_bit() that includes a
  full memory barrier on some platforms, therefore use
  smp_mb__after_atomic to avoid overhead

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/80085451-3eaf-507a-c7c0-08d607c46fbc@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c