OSDN Git Service

drm/rockchip: use drm_gem_mmap helpers
authorDaniel Kurtz <djkurtz@chromium.org>
Tue, 7 Jul 2015 09:03:36 +0000 (17:03 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 7 Jul 2015 12:04:06 +0000 (14:04 +0200)
commit41315b793e13f884cda79389f0d5d44d027e57d1
tree3bff9505a4e9ed56002ce9a13a218aaf17b19b1d
parente24ff467e12e1560de753313976c46e84fa6306a
drm/rockchip: use drm_gem_mmap helpers

Rather than (incompletely [0]) re-implementing drm_gem_mmap() and
drm_gem_mmap_obj() helpers, call them directly from the rockchip mmap
routines.

Once the core functions return successfully, the rockchip mmap routines
can still use dma_mmap_attrs() to simply mmap the entire buffer.

[0] Previously, we were performing the mmap() without first taking a
reference on the underlying gem buffer.  This could leak ptes if the gem
object is destroyed while userspace is still holding the mapping.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/rockchip/rockchip_drm_gem.c