OSDN Git Service

soc: renesas: Add missing check for non-zero product register address
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 16 Oct 2019 14:33:06 +0000 (16:33 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 1 Nov 2019 13:25:33 +0000 (14:25 +0100)
commit4194b583c104922c6141d6610bfbce26847959df
treed6d2aeff3ee9cecee94c19115e09740bc3e29630
parent6655c568ced0789479f00b9399603c5d6ee48640
soc: renesas: Add missing check for non-zero product register address

If the DTB for a device with an RZ/A2 SoC lacks a device node for the
BSID register, the ID validation code falls back to using a register at
address 0x0, which leads to undefined behavior (e.g. reading back a
random value).

This could be fixed by letting fam_rza2.reg point to the actual BSID
register.  However, the hardcoded fallbacks were meant for backwards
compatibility with old DTBs only, not for new SoCs.  Hence fix this by
validating renesas_family.reg before using it.

Fixes: 175f435f44b724e3 ("soc: renesas: identify RZ/A2")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20191016143306.28995-1-geert+renesas@glider.be
drivers/soc/renesas/renesas-soc.c