OSDN Git Service

parisc: led: Fix potential null-ptr-deref in start_task()
authorShang XiaoJing <shangxiaojing@huawei.com>
Thu, 17 Nov 2022 02:45:14 +0000 (10:45 +0800)
committerHelge Deller <deller@gmx.de>
Sat, 17 Dec 2022 22:19:38 +0000 (23:19 +0100)
commit41f563ab3c33698bdfc3403c7c2e6c94e73681e4
tree709401d0bddad8e5890de63441371c067bdf594e
parent1bc5434632593ea3bb3a1ed2499af8c31796448b
parisc: led: Fix potential null-ptr-deref in start_task()

start_task() calls create_singlethread_workqueue() and not checked the
ret value, which may return NULL. And a null-ptr-deref may happen:

start_task()
    create_singlethread_workqueue() # failed, led_wq is NULL
    queue_delayed_work()
        queue_delayed_work_on()
            __queue_delayed_work()  # warning here, but continue
                __queue_work()      # access wq->flags, null-ptr-deref

Check the ret value and return -ENOMEM if it is NULL.

Fixes: 3499495205a6 ("[PARISC] Use work queue in LED/LCD driver instead of tasklet.")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: <stable@vger.kernel.org>
drivers/parisc/led.c