OSDN Git Service

media: i2c: mt9v111: Fix v4l2-ctrl error handling
authorJacopo Mondi <jacopo+renesas@jmondi.org>
Fri, 3 Aug 2018 10:40:58 +0000 (12:40 +0200)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 10 Sep 2018 16:13:41 +0000 (12:13 -0400)
commit422e91cc48f8661273311e96cee9d8b1115aa788
tree2dec937bdda1fb46742552638a60b86fe58b3247
parentd842a7cf938b6e0f8a1aa9f1aec0476c9a599310
media: i2c: mt9v111: Fix v4l2-ctrl error handling

Fix error handling of v4l2_ctrl creation by inspecting the ctrl.error flag
instead of testing for each returned value correctness.

As reported by Dan Carpenter returning PTR_ERR() on the v4l2_ctrl_new_std()
return value is also wrong, as that function return NULL on error.

While at there re-order the cleanup path to respect the operation inverse
order.

Fixes: aab7ed1c "media: i2c: Add driver for Aptina MT9V111"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/media/i2c/mt9v111.c