OSDN Git Service

sunrpc: correct the computation for page_ptr when truncating
authorFrank Sorenson <sorenson@redhat.com>
Tue, 30 Oct 2018 20:10:40 +0000 (15:10 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:27:44 +0000 (09:27 +0100)
commit4293fbc271e4da53c690a1c913ad3b2252b575ab
tree698423b6b0a78ae095402ba8713a99cf78ed2b78
parentf7e6ee2e18cc745f05a9fe678de65ac24a6adcfd
sunrpc: correct the computation for page_ptr when truncating

commit 5d7a5bcb67c70cbc904057ef52d3fcfeb24420bb upstream.

When truncating the encode buffer, the page_ptr is getting
advanced, causing the next page to be skipped while encoding.
The page is still included in the response, so the response
contains a page of bogus data.

We need to adjust the page_ptr backwards to ensure we encode
the next page into the correct place.

We saw this triggered when concurrent directory modifications caused
nfsd4_encode_direct_fattr() to return nfserr_noent, and the resulting
call to xdr_truncate_encode() corrupted the READDIR reply.

Signed-off-by: Frank Sorenson <sorenson@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/xdr.c