OSDN Git Service

jffs2: Hook up splice_write callback
authorJoel Stanley <joel@jms.id.au>
Tue, 30 Mar 2021 13:45:37 +0000 (00:15 +1030)
committerRichard Weinberger <richard@nod.at>
Thu, 15 Apr 2021 20:01:14 +0000 (22:01 +0200)
commit42984af09afc414d540fcc8247f42894b0378a91
tree2ccbce216b354bba6a350633c61b41d0a834ba90
parent81af4b7b53d3f2931db907c90822d0b89f0166b7
jffs2: Hook up splice_write callback

overlayfs using jffs2 as the upper filesystem would fail in some cases
since moving to v5.10. The test case used was to run 'touch' on a file
that exists in the lower fs, causing the modification time to be
updated. It returns EINVAL when the bug is triggered.

A bisection showed this was introduced in v5.9-rc1, with commit
36e2c7421f02 ("fs: don't allow splice read/write without explicit ops").
Reverting that commit restores the expected behaviour.

Some digging showed that this was due to jffs2 lacking an implementation
of splice_write. (For unknown reasons the warn_unsupported that should
trigger was not displaying any output).

Adding this patch resolved the issue and the test now passes.

Cc: stable@vger.kernel.org
Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Lei YU <yulei.sh@bytedance.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/jffs2/file.c