OSDN Git Service

hw/acpi: Fix PM control register access
authorBALATON Zoltan <balaton@eik.bme.hu>
Wed, 7 Jun 2023 20:01:25 +0000 (22:01 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 26 Jun 2023 13:49:24 +0000 (09:49 -0400)
commit42b1b9d7db48e72b10760869de20070b4afb6c2c
tree5609b72aa735d7f59c68bf54884fa21149260c12
parenta1f85cff902f3260d85c74ec11d4c4b182cead80
hw/acpi: Fix PM control register access

On pegasos2 which has ACPI as part of VT8231 south bridge the board
firmware writes PM control register by accessing the second byte so
addr will be 1. This wasn't handled correctly and the write went to
addr 0 instead. Remove the acpi_pm1_cnt_write() function which is used
only once and does not take addr into account and handle non-zero
address in acpi_pm_cnt_{read|write}. This fixes ACPI shutdown with
pegasos2 firmware.

The issue below is possibly related to the same memory core bug.

Link: https://gitlab.com/qemu-project/qemu/-/issues/360
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20230607200125.A9988746377@zero.eik.bme.hu>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/acpi/core.c