OSDN Git Service

leds: fix led_brightness_set when soft-blinking
authorFabio Baltieri <fabio.baltieri@gmail.com>
Wed, 6 Jun 2012 19:12:34 +0000 (03:12 +0800)
committerBryan Wu <bryan.wu@canonical.com>
Mon, 23 Jul 2012 23:52:34 +0000 (07:52 +0800)
commit437864828d82b9dee50b5741106fbf5fa12b139a
tree356c64833d43ff01b36277aa7bcf556e6ee367b1
parent3740e49c668bbe7719f292c24c4c5f152a88b97e
leds: fix led_brightness_set when soft-blinking

Move led_stop_software_blink() code into led_brightness_set() to ensure
software blink timer is stopped and cleared when changing trigger.

Also use led_set_brightness() instead of calling
led_cdev->brightness_set() directly to keep led_cdev->brightness
consistent with current LED status.

This ensure proper cleaning when changing triggers, as without this fix
a LED may be turned off while leaving it's led_cdev->brightness = 1,
leading to an erratic software-blink behaviour.

The problem was easy to reproduce by changing the trigger from "timer"
to "oneshot".

Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
drivers/leds/led-core.c