OSDN Git Service

of: fix clang -Wunsequenced for be32_to_cpu()
authorPhong Tran <tranmanphong@gmail.com>
Tue, 30 Apr 2019 14:56:24 +0000 (21:56 +0700)
committerRob Herring <robh@kernel.org>
Wed, 1 May 2019 19:26:36 +0000 (14:26 -0500)
commit440868661f36071886ed360d91de83bd67c73b4f
tree458324b634f0f15bd140ff3bcfd3b88425768f87
parent8e94fd36220cb541ab536214bd9993035251cd5c
of: fix clang -Wunsequenced for be32_to_cpu()

Now, make the loop explicit to avoid clang warning.

./include/linux/of.h:238:37: warning: multiple unsequenced modifications
to 'cell' [-Wunsequenced]
                r = (r << 32) | be32_to_cpu(*(cell++));
                                                  ^~
./include/linux/byteorder/generic.h:95:21: note: expanded from macro
'be32_to_cpu'
                    ^
./include/uapi/linux/byteorder/little_endian.h:40:59: note: expanded
from macro '__be32_to_cpu'
                                                          ^
./include/uapi/linux/swab.h:118:21: note: expanded from macro '__swab32'
        ___constant_swab32(x) :                 \
                           ^
./include/uapi/linux/swab.h:18:12: note: expanded from macro
'___constant_swab32'
        (((__u32)(x) & (__u32)0x000000ffUL) << 24) |            \
                  ^

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/460
Suggested-by: David Laight <David.Laight@ACULAB.COM>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Cc: stable@vger.kernel.org
[robh: fix up whitespace]
Signed-off-by: Rob Herring <robh@kernel.org>
include/linux/of.h