OSDN Git Service

(root) / android-x86 / frameworks-base.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ab6fb6f) | patch
Don't proxy calls to DocumentsAdapter in MultiSelManager.
authorSteve McKay <smckay@google.com>
Tue, 5 Jan 2016 23:27:17 +0000 (15:27 -0800)
committerSteve McKay <smckay@google.com>
Tue, 5 Jan 2016 23:50:35 +0000 (15:50 -0800)
commit44408260ba99eea55f7c0ec02778bb13d83c3262
treeff65decbf9e47d1d6ad86be3ab62c181582fd9betree | snapshot
parentab6fb6fcaf9b2406697971f7464d331b6d1d46b5commit | diff
Don't proxy calls to DocumentsAdapter in MultiSelManager.

We were bouncing calls out to the adapter pulled from RecyclerView,
but the adapter is easy to write a test double for and
we can readily inject the adapter when needed at runtime.

Eliminates unnecessary indirection.
Also, protect against failure when documents can't be loaded for delete.

Change-Id: Ief6585bf2e3e4fd407d801d485a9d7cd888b8500
packages/DocumentsUI/src/com/android/documentsui/dirlist/DirectoryFragment.java diff | blob | history
packages/DocumentsUI/src/com/android/documentsui/dirlist/Model.java diff | blob | history
packages/DocumentsUI/src/com/android/documentsui/dirlist/MultiSelectManager.java diff | blob | history
packages/DocumentsUI/tests/src/com/android/documentsui/dirlist/ModelBackedDocumentsAdapterTest.java diff | blob | history
packages/DocumentsUI/tests/src/com/android/documentsui/dirlist/MultiSelectManagerTest.java diff | blob | history
packages/DocumentsUI/tests/src/com/android/documentsui/dirlist/MultiSelectManager_GridModelTest.java diff | blob | history
packages/DocumentsUI/tests/src/com/android/documentsui/dirlist/TestDocumentsAdapter.java [new file with mode: 0644] blob
packages/DocumentsUI/tests/src/com/android/documentsui/dirlist/TestSelectionEnvironment.java diff | blob | history
frameworks/base
About OSDN
Find Software
Develop Software
Help