OSDN Git Service

brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain
authorPeter S. Housel <housel@acm.org>
Mon, 12 Jun 2017 10:46:22 +0000 (11:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Nov 2018 15:41:38 +0000 (07:41 -0800)
commit44656b939099b3381134dfe7c1cf5ccfc08d3272
treec881c39caf0f3308e47b2bb94a13b67763a4e0c7
parent02bc5312bb66a828f21d85af14425fd45eec08f8
brcmfmac: Fix glom_skb leak in brcmf_sdiod_recv_chain

[ Upstream commit 5ea59db8a375216e6c915c5586f556766673b5a7 ]

An earlier change to this function (3bdae810721b) fixed a leak in the
case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the
glom_skb buffer, used for emulating a scattering read, is never used
or referenced after its contents are copied into the destination
buffers, and therefore always needs to be freed by the end of the
function.

Fixes: 3bdae810721b ("brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain")
Fixes: a413e39a38573 ("brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support")
Cc: stable@vger.kernel.org # 4.9.x-
Signed-off-by: Peter S. Housel <housel@acm.org>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c