OSDN Git Service

ALSA: compress: Fix regression on compressed capture streams
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Mon, 22 Jul 2019 09:24:33 +0000 (10:24 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 23 Jul 2019 10:07:22 +0000 (12:07 +0200)
commit4475f8c4ab7b248991a60d9c02808dbb813d6be8
treef8f5c775046810dc8e211453d10f8c3c0b42dbf4
parente4091bdd2fd957793a10449a8682c767578b0430
ALSA: compress: Fix regression on compressed capture streams

A previous fix to the stop handling on compressed capture streams causes
some knock on issues. The previous fix updated snd_compr_drain_notify to
set the state back to PREPARED for capture streams. This causes some
issues however as the handling for snd_compr_poll differs between the
two states and some user-space applications were relying on the poll
failing after the stream had been stopped.

To correct this regression whilst still fixing the original problem the
patch was addressing, update the capture handling to skip the PREPARED
state rather than skipping the SETUP state as it has done until now.

Fixes: 4f2ab5e1d13d ("ALSA: compress: Fix stop handling on compressed capture streams")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/compress_driver.h
sound/core/compress_offload.c