OSDN Git Service

kunit: Add gnu_printf specifiers
authorDavid Gow <davidgow@google.com>
Thu, 13 May 2021 20:03:50 +0000 (13:03 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 23 Jun 2021 23:06:04 +0000 (17:06 -0600)
commit44acdbb250a57240ec113f12bd6229854681ea5f
tree63db8f2396302ed07607692114a51dd4c3c08594
parent255ede3b129041eae4edfdce121cedbfabfdd30e
kunit: Add gnu_printf specifiers

Some KUnit functions use variable arguments to implement a printf-like
format string. Use the __printf() attribute to let the compiler warn if
invalid format strings are passed in.

If the kernel is build with W=1, it complained about the lack of these
specifiers, e.g.:
../lib/kunit/test.c:72:2: warning: function ‘kunit_log_append’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Acked-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h
lib/kunit/string-stream.h