OSDN Git Service

target-sparc: fix ldstub sign-extension bug
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Sat, 9 Apr 2016 11:25:12 +0000 (12:25 +0100)
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Mon, 11 Apr 2016 15:25:07 +0000 (16:25 +0100)
commit4553e10360a0713e31647220ed396942f9a6fca0
treec7e45993f99ac463c921b27a6ff984bdde26e700
parentdc1ffa66619b3661f17a309b0aa8d65d8d29583f
target-sparc: fix ldstub sign-extension bug

ldstub [addr], reg incorrectly reads a signed byte from memory which causes
problems in the 32-bit Solaris mutex code. Here the byte value being read is
0xff which is incorrectly sign-extended to 0xffffffff before being written back
to the target register causing lock detection to behave incorrectly.

This fixes the intermittent hangs and MUTEX_HELD warnings issued to the
console when running 32-bit Solaris images under qemu-system-sparc.

With thanks to Joseph Dery for providing a condensed test image to consistently
reproduce the problem on demand, and Martin Husemann for allowing me access to
real hardware for comparison.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-By: Artyom Tarasenko <atar4qemu@gmail.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
target-sparc/translate.c