OSDN Git Service

f2fs: wait on atomic writes to count F2FS_CP_WB_DATA
authorJaegeuk Kim <jaegeuk@kernel.org>
Fri, 28 Dec 2018 19:00:38 +0000 (11:00 -0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 4 Jan 2019 21:07:54 +0000 (13:07 -0800)
commit45afbd380596bb505970070d9521d607de22bd6b
tree17ed3da6467d636395c2d932b9c1015b77b5b649
parent91aae9fd92425b92712b6fe9ad059dd56f926364
f2fs: wait on atomic writes to count F2FS_CP_WB_DATA

Otherwise, we can get wrong counts incurring checkpoint hang.

IO_W (CP:  -24, Data:   24, Flush: (   0    0    1), Discard: (   0    0))

Thread A                        Thread B
- f2fs_write_data_pages
 -  __write_data_page
  - f2fs_submit_page_write
   - inc_page_count(F2FS_WB_DATA)
     type is F2FS_WB_DATA due to file is non-atomic one
- f2fs_ioc_start_atomic_write
 - set_inode_flag(FI_ATOMIC_FILE)
                                - f2fs_write_end_io
                                 - dec_page_count(F2FS_WB_CP_DATA)
                                   type is F2FS_WB_DATA due to file becomes
                                   atomic one

Cc: <stable@vger.kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c