OSDN Git Service

ALSA: atmel: ac97: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 15 Mar 2023 15:04:56 +0000 (16:04 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 20 Mar 2023 13:07:01 +0000 (13:07 +0000)
commit45cc35e81322117dfc27fbfded2e0263018175a0
tree0edf66b1b8b4a465bacd403b1934714348ab4b8f
parent3210e62ab2f63b3ecdacc2c06ca8c8a91d1bf656
ALSA: atmel: ac97: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/atmel/ac97c.c