OSDN Git Service

(root) / android-x86 / frameworks-base.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: af34bd5) | patch
Fix clang-tidy warnings in aapt and aapt2.
authorChih-Hung Hsieh <chh@google.com>
Mon, 15 Aug 2016 19:32:51 +0000 (12:32 -0700)
committerChih-Hung Hsieh <chh@google.com>
Mon, 15 Aug 2016 19:32:51 +0000 (12:32 -0700)
commit470f8fcb5c0c59b28b5f73ee011a797b05085da7
tree94b3c5f77f57476c0f314edb53a01e90220cbfb0tree | snapshot
parentaf34bd5caeeaed956f3f6728a076799b11fe9406commit | diff
Fix clang-tidy warnings in aapt and aapt2.

* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Add NOLINT to suppress wrong clang-tidy warnings on macros.
Test: build with WITH_TIDY=1

Change-Id: Ibfafb23d9be463b4072745a51a6d9f1812dcac45
22 files changed:
tools/aapt2/Diagnostics.h diff | blob | history
tools/aapt2/NameMangler.h diff | blob | history
tools/aapt2/Source.h diff | blob | history
tools/aapt2/ValueVisitor.h diff | blob | history
tools/aapt2/compile/Png.h diff | blob | history
tools/aapt2/compile/Pseudolocalizer.h diff | blob | history
tools/aapt2/flatten/TableFlattener.h diff | blob | history
tools/aapt2/io/FileSystem.h diff | blob | history
tools/aapt2/io/ZipArchive.h diff | blob | history
tools/aapt2/java/ClassDefinition.h diff | blob | history
tools/aapt2/link/ManifestFixer.h diff | blob | history
tools/aapt2/link/ProductFilter.h diff | blob | history
tools/aapt2/process/SymbolTable.h diff | blob | history
tools/aapt2/test/Builders.h diff | blob | history
tools/aapt2/test/Common.h diff | blob | history
tools/aapt2/test/Context.h diff | blob | history
tools/aapt2/util/BigBuffer.h diff | blob | history
tools/aapt2/util/Files.h diff | blob | history
tools/aapt2/util/Maybe.h diff | blob | history
tools/aapt2/util/StringPiece.h diff | blob | history
tools/aapt2/util/Util.h diff | blob | history
tools/aapt2/xml/XmlPullParser.h diff | blob | history
frameworks/base
About OSDN
Find Software
Develop Software
Help